Skip to content

Conversation

@julionav
Copy link
Contributor

@julionav julionav commented Apr 21, 2025

Context

Right now you cannot import your settings into roo without adding a new API key #2208

Implementation

  • Added new button to WelcomeView.tsx that starts the import settings process

  • Updated import logic to set a provider in the ContextProxy. This was required to allow the app to stop showing the welcome screen.

    • For some reason there are 2 places holding the API configs. ContextProxy and ProviderSettingsManager -- I guess is code from Cline. Without the proivider in ContextProxy the app thinks that no api has been configured, even though there are several API config in the provider

Screenshots

before after
image image

How to Test

Get in Touch

Discord: profotium


Important

Add "Import Settings" button to welcome screen and update import logic to handle provider settings in ContextProxy.

  • UI Changes:
    • Added "Import Settings" button to WelcomeView.tsx.
  • Import Logic:
    • Updated importSettings in importExport.ts to set provider settings in ContextProxy.
  • Translations:
    • Added "Import Settings" translation in welcome.json for multiple languages including en, es, fr, de, zh-CN, zh-TW, hi, it, pl, pt-BR, vi, and ca.

This description was created by Ellipsis for 6765bdd. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 9921bf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 21, 2025
@dosubot dosubot bot added the enhancement New feature or request label Apr 21, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 21, 2025

@cte do you mind taking a look at this? Agree that it makes sense to allow for settings import on the welcome screen somehow. Thanks!

@adamhill
Copy link
Contributor

I think it should be more part of the onboarding flow (maybe a 2nd "OR" block, since it would pull in your keys too)

wdyt @sachasayan @elianiva

@elianiva
Copy link
Contributor

i prefer having something that's more visible, like a second OR block or some sort like Adam said

currently it's using small text and users might miss them—due to themes and whatnot

also having it on a separate section aligns with what we have now, so it'll give the impression of

  • you're new? try using requesty or openrouter for a start
  • you've dabbled in before? cool, you can bring your own api key using this menu
  • oh you've done this before? gotcha, use this button to import your old stuff

at the moment i feel like it gives the impression of psst, here's the import settings button due to it being small

we can also add some explanations if we decide to add it on its own section, like "importing settings will NOT import your api key" or something like that
it helps setting the users expectation on what this "import settings" button actually do

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 22, 2025
@sachasayan
Copy link
Contributor

This is great and I'm fine with merging it as-is and doing another pass for UI improvements later. I agree this is a screen which could use some more love and I think a dedicated PR for that is best.

Could you fix the failing tests, @julionav?

Also, for anyone who knows: How much complexity is there in removing the provider from the proxy and keeping providerSettingsManager as source of truth for apiConfig, as mentioned in the code?

@cte cte changed the title Feat: Add a new button to import settings on the welcome screen. Feat: Add a new button to import settings on the welcome screen Apr 28, 2025
@cte cte merged commit 04fa72e into RooCodeInc:main Apr 28, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 28, 2025
shariqriazz pushed a commit to shariqriazz/Roo-Code that referenced this pull request Apr 29, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* Remove controllerRef

* Remove webviewProviderRef

* Remove controllerRef

* Fix test

* Create odd-jeans-wash.md

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial installation should support importing settings from JSON file

6 participants